Re: [PATCH 4/4] staging/vchi: Remove dependency on CONFIG_BROKEN.

[Stefan Wahren]

Hi Greg,

> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> hat am 15. Oktober 2016 um
> 13:27 geschrieben:
> 
> 
> On Sat, Oct 15, 2016 at 10:35:25AM +0200, Stefan Wahren wrote:
> > 
> > > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> hat am 13. Oktober 2016 um
> > > 09:05 geschrieben:
> > > 
> > > 
> > > On Mon, Oct 03, 2016 at 11:52:09AM -0700, Eric Anholt wrote:
> > > > The driver builds now.
> > > > 
> > > > Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> > > > ---
> > > >  drivers/staging/vc04_services/Kconfig | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/vc04_services/Kconfig
> > > > b/drivers/staging/vc04_services/Kconfig
> > > > index 9676fb29075a..db8e1beb89f9 100644
> > > > --- a/drivers/staging/vc04_services/Kconfig
> > > > +++ b/drivers/staging/vc04_services/Kconfig
> > > > @@ -1,6 +1,6 @@
> > > >  config BCM2708_VCHIQ
> > > >  	tristate "Videocore VCHIQ"
> > > > -	depends on RASPBERRYPI_FIRMWARE && BROKEN
> > > > +	depends on RASPBERRYPI_FIRMWARE
> > > >  	default y
> > > >  	help
> > > >  		Kernel to VideoCore communication interface for the
> > > 
> > > I've dropped this patch from my branch as there are build errors on
> > > arm64 systems still, and we don't want regressions like that.
> > > 
> > > I've forwarded you the error messages, and I'll be glad to add this
> > > patch back once these issues are fixed.
> > 
> > I ask the author of this downstream pull request [1] to send the VHCIQ part
> > as
> > indiviual patches.
> > He is interested to submit them upstream.
> > 
> > [1] - https://github.com/raspberrypi/linux/pull/1611
> 
> Ok, but what does that mean for us here?  The code should be all now
> merged into our "upstream" trees, it just needs to be cleaned up
> properly.
> 
> confused,
> 
> greg k-h

sorry for the confusion. I mean that he wants to send email patches based on
your staging tree. So we avoid patching the kernel twice.

The link was only for illustration that he already fixed most of the arm64 build
issues.

Stefan