Re: [PATCH v2] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

From: David Miller
Date: Sat Oct 15 2016 - 17:48:42 EST

From: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
Date: Sat, 15 Oct 2016 00:01:20 +0300

> vmxnet3_set_mc() checks new_table_pa returned by dma_map_single()
> with dma_mapping_error(), but even there it assumes zero is invalid pa
> (it assumes dma_mapping_error(...,0) returns true if new_table is NULL).
> The patch adds an explicit variable to track status of new_table_pa.
> Found by Linux Driver Verification project (
> v2: use "bool" and "true"/"false" for boolean variables.
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>