Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig

[Andy Shevchenko]

On Sun, 2016-10-23 at 12:45 +0000, vadimp@xxxxxxxxxxxx wrote:
> From: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
> 
> Add select HWMON for mlxcpld-hotplug driver config, since it requires
> hwmon APIs.
> 
> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
> ---
> Âdrivers/platform/x86/Kconfig | 1 +
> Â1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig
> b/drivers/platform/x86/Kconfig
> index 65d9b04..1853769 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
> Â	tristate "Mellanox platform hotplug driver support"


> Â	default n

Btw, I thought the _default_ is 'n' and thus this line is not needed.

> Â	depends on MLX_PLATFORM
> +	select HWMON
> Â	select I2C
> Â	---help---
> Â	ÂÂThis driver handles hot-plug events for the power
> suppliers, power

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy