Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions

From: Dan Carpenter
Date: Mon Oct 24 2016 - 05:36:15 EST


On Sat, Oct 22, 2016 at 06:29:55PM +0100, Jonathan Cameron wrote:
> On 19/10/16 12:37, Dan Carpenter wrote:
> > I appologize for laughing, but I am still secretly amused in my heart.
> >
> > regards,
> > dan carpenter
> >
> Fewer beers or less caffeine for Dan!

;)

>
> Key take away here is keep things simple. The gotos in my mind
> would actually have made sense, but I wouldn't do the refactoring until
> you need it. i.e. when you introduce the locking in this patch.

Yeah, I totally agree do it when you need it. I like gotos if they're
needed.

regards,
dan carpenter