Re: [PATCH] Staging:board:board: fix implicit declaration of function

[Geert Uytterhoeven]

On Mon, Oct 24, 2016 at 12:46 PM, Dan Carpenter
<dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote:
>> implicit declaration of function âof_find_all_nodesâ reported by sparse
>>
>
> No.  Include the correct header file instead.

drivers/staging/board/board.c already includes <linux/of.h>, which provides
the prototype, but only if CONFIG_OF=y.

However, STAGING_BOARD depends on OF_ADDRESS and OF_IRQ,
which both depend on OF. So how can this happen??

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds