Re: [PATCH 1/4] MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()
From: Theodore Ts'o
Date: Mon Oct 24 2016 - 09:13:56 EST
On Mon, Oct 24, 2016 at 02:27:55PM +0200, SF Markus Elfring wrote:
>
> A string which did not contain a data format specification should be put
> into a sequence.
This is not a correct description of what you are doing. A better
description would be to say:
"Use seq_put[sc]() instead of seq_printf() since the string does not
contain a data format specifier". You should fix this in all the
patches. Please also note this is really pointless patch, since
reading from /proc isn't done in a tight loop, and even if it were,
the use of vsprintf is the tiniest part of the overhead. It otherwise
reduces the text space or the number of lines of code....
- Ted