Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox hotplug driver in Kconfig

[Randy Dunlap]

On 10/23/16 22:41, Vadim Pasternak wrote:
> 
> 
>> -----Original Message-----
>> From: Randy Dunlap [mailto:rdunlap@xxxxxxxxxxxxx]
>> Sent: Sunday, October 23, 2016 7:57 PM
>> To: Vadim Pasternak <vadimp@xxxxxxxxxxxx>; dvhart@xxxxxxxxxxxxx;
>> fengguang.wu@xxxxxxxxx
>> Cc: davem@xxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx; akpm@linux-
>> foundation.org; kvalo@xxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
>> mchehab@xxxxxxxxxx; linux@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> platform-driver-x86@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx;
>> andriy.shevchenko@xxxxxxxxxxxxxxx
>> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox
>> hotplug driver in Kconfig
>>
>> On 10/23/16 05:45, vadimp@xxxxxxxxxxxx wrote:
>>> From: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
>>>
>>> Add select HWMON for mlxcpld-hotplug driver config, since it requires
>>> hwmon APIs.
>>>
>>> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx>
>>> ---
>>>  drivers/platform/x86/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/Kconfig
>>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM
>>>  	tristate "Mellanox platform hotplug driver support"
>>>  	default n
>>>  	depends on MLX_PLATFORM
>>> +	select HWMON
>>>  	select I2C
>>>  	---help---
>>>  	  This driver handles hot-plug events for the power suppliers, power
>>>
>>
>> Hi,
>> did you test this?  I would expect it to cause a kconfig warning, something about
>> HWMON having a dependency on HAS_IOMEM.
> 
> Hi Randy,
> 
> Yes, 
> I built tree with this fix with the attached .config file.
> Didn't see kconfig warnings.
> I can have a look again.

No need. lib/Kconfig handles it:

config HAS_IOMEM
	bool
	depends on !NO_IOMEM
	select GENERIC_IO
	default y


thanks.
-- 
~Randy