Re: [RESEND PATCH v3 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

From: Michael S. Tsirkin
Date: Mon Oct 24 2016 - 23:52:24 EST


On Sun, Oct 23, 2016 at 11:29:25AM +0000, Li, Liang Z wrote:
> > On Fri, Oct 21, 2016 at 10:25:21AM -0700, Dave Hansen wrote:
> > > On 10/20/2016 11:24 PM, Liang Li wrote:
> > > > Dave Hansen suggested a new scheme to encode the data structure,
> > > > because of additional complexity, it's not implemented in v3.
> > >
> > > So, what do you want done with this patch set? Do you want it applied
> > > as-is so that we can introduce a new host/guest ABI that we must
> > > support until the end of time? Then, we go back in a year or two and
> > > add the newer format that addresses the deficiencies that this ABI has
> > > with a third version?
> > >
> >
> > Exactly my questions.
>
> Hi Dave & Michael,
>
> In the V2, both of you thought that the memory I allocated for the bitmap is too large, and gave some
> suggestions about the solution, so I changed the implementation and used scattered pages for the bitmap
> instead of a large physical continued memory. I didn't get the comments about the changes, so I am not
> sure whether that is OK or not, that's the why I resend the V3, I just want your opinions about that part.
>
> I will implement the new schema as Dave suggested in V4. Before that, could you take a look at this version and
> give some comments?
>
> Thanks!
> Liang

Sure, I'll try to review just that part.