Re: [PATCH][V2] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks

[Alex Deucher]

On Tue, Oct 25, 2016 at 3:43 AM, Christian KÃnig
<christian.koenig@xxxxxxx> wrote:
> Am 25.10.2016 um 01:14 schrieb Colin King:
>>
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to
>> printk messages.  Remove redundant spaces before \n too (thanks to
>> Joe Perches for spotting those).
>>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
>
> Reviewed-by: Christian KÃnig <christian.koenig@xxxxxxx>.
>

Applied.  Thanks!

Alex

>
>> ---
>>   drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c      | 4 ++--
>>   drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c   | 4 ++--
>>   drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 ++--
>>   drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c     | 4 ++--
>>   4 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
>> b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
>> index 76310ac..62e99d7 100644
>> --- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
>> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
>> @@ -2125,7 +2125,7 @@ uint32_t fiji_get_offsetof(uint32_t type, uint32_t
>> member)
>>                         return offsetof(SMU73_Discrete_DpmTable,
>> LowSclkInterruptThreshold);
>>                 }
>>         }
>> -       printk("cant't get the offset of type %x member %x \n", type,
>> member);
>> +       printk(KERN_WARNING "can't get the offset of type %x member %x\n",
>> type, member);
>>         return 0;
>>   }
>>   @@ -2150,7 +2150,7 @@ uint32_t fiji_get_mac_definition(uint32_t value)
>>                 return SMU73_MAX_LEVELS_MVDD;
>>         }
>>   -     printk("cant't get the mac of %x \n", value);
>> +       printk(KERN_WARNING "can't get the mac of %x\n", value);
>>         return 0;
>>   }
>>   diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
>> b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
>> index 8c889ca..0cc20a8 100644
>> --- a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
>> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
>> @@ -2140,7 +2140,7 @@ uint32_t iceland_get_offsetof(uint32_t type,
>> uint32_t member)
>>                         return offsetof(SMU71_Discrete_DpmTable,
>> LowSclkInterruptThreshold);
>>                 }
>>         }
>> -       printk("cant't get the offset of type %x member %x \n", type,
>> member);
>> +       printk(KERN_WARNING "can't get the offset of type %x member %x\n",
>> type, member);
>>         return 0;
>>   }
>>   @@ -2163,7 +2163,7 @@ uint32_t iceland_get_mac_definition(uint32_t
>> value)
>>                 return SMU71_MAX_LEVELS_MVDD;
>>         }
>>   -     printk("cant't get the mac of %x \n", value);
>> +       printk(KERN_WARNING "can't get the mac of %x\n", value);
>>         return 0;
>>   }
>>   diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
>> b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
>> index 4ccc0b7..7236c51 100644
>> --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
>> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
>> @@ -2174,7 +2174,7 @@ uint32_t polaris10_get_offsetof(uint32_t type,
>> uint32_t member)
>>                         return offsetof(SMU74_Discrete_DpmTable,
>> LowSclkInterruptThreshold);
>>                 }
>>         }
>> -       printk("cant't get the offset of type %x member %x \n", type,
>> member);
>> +       printk(KERN_WARNING "can't get the offset of type %x member %x\n",
>> type, member);
>>         return 0;
>>   }
>>   @@ -2201,7 +2201,7 @@ uint32_t polaris10_get_mac_definition(uint32_t
>> value)
>>                 return SMU7_UVD_MCLK_HANDSHAKE_DISABLE;
>>         }
>>   -     printk("cant't get the mac of %x \n", value);
>> +       printk(KERN_WARNING "can't get the mac of %x\n", value);
>>         return 0;
>>   }
>>   diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
>> b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
>> index de2a24d..d08f6f1 100644
>> --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
>> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
>> @@ -2651,7 +2651,7 @@ uint32_t tonga_get_offsetof(uint32_t type, uint32_t
>> member)
>>                         return offsetof(SMU72_Discrete_DpmTable,
>> LowSclkInterruptThreshold);
>>                 }
>>         }
>> -       printk("cant't get the offset of type %x member %x\n", type,
>> member);
>> +       printk(KERN_WARNING "can't get the offset of type %x member %x\n",
>> type, member);
>>         return 0;
>>   }
>>   @@ -2675,7 +2675,7 @@ uint32_t tonga_get_mac_definition(uint32_t value)
>>         case SMU_MAX_LEVELS_MVDD:
>>                 return SMU72_MAX_LEVELS_MVDD;
>>         }
>> -       printk("cant't get the mac value %x\n", value);
>> +       printk(KERN_WARNING "can't get the mac value %x\n", value);
>>         return 0;
>>   }
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel