Re: [PATCH 5/5] ARM: dts: Add LEGO MINDSTORTMS EV3 dts

[David Lechner]

On 10/25/2016 05:58 AM, Sekhar Nori wrote:
> On Tuesday 25 October 2016 02:50 AM, David Lechner wrote:
> > On 10/24/2016 02:50 PM, David Lechner wrote:
> > > On 10/24/2016 10:50 AM, David Lechner wrote:
> > > > On 10/24/2016 06:58 AM, Sekhar Nori wrote:
> > > > > On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
> > > > >
> > > > > > +&ehrpwm1 {
> > > > > > +    status = "disabled";
> > > > >
> > > > > Hmm, disabled? Can you add this node when you actually use it?
> > > >
> > > > Not sure why I have this disabled. Like the gpios, the pwms can be used
> > > > via sysfs, so I would like to leave them.
> > >
> > > Now I remember why these are disabled. The clock matching is broken.
> > > Only the first ehrpwm and the first ecap get clocks. The others fail.
> > >
> > > I can change these to "okay". It will just result in a kernel error
> > > message until the clocks are fixed.
> >
> > correction: it is not the clocks that are broken. it is the device names.
> >
> > In  arch/arm/mach-davinci/da8xx-dt.c, we have...
> >
> >
> >     OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f00000, "ehrpwm", NULL),
> >     OF_DEV_AUXDATA("ti,da850-ehrpwm", 0x01f02000, "ehrpwm", NULL),
> >     OF_DEV_AUXDATA("ti,da850-ecap", 0x01f06000, "ecap", NULL),
> >     OF_DEV_AUXDATA("ti,da850-ecap", 0x01f07000, "ecap", NULL),
> >     OF_DEV_AUXDATA("ti,da850-ecap", 0x01f08000, "ecap", NULL),
> >
> >
> > Which causes each device to have the same device node name. This causes
> > sysfs errors because it is trying to register a second device at the
> > same sysfs path.
> >
> > If you change the names here, then the device do not work because the
> > clock lookup fails.
>
> Yeah, this is incorrect (I should have caught it in review). The device
> id should have been present in the lookup. Can you fix auxdata and clock
> lookup too and send a separate patch? Its probably a v4.9-rc candidate.
>
> Thanks,
> Sekhar

Yes, I can do this.