Re: [PATCH 1/2] perf, x86-mm: Add exit-fault tracing

[Peter Zijlstra]

On Wed, Oct 26, 2016 at 01:51:59AM +0200, Alexis Berlemont wrote:

-ENOCHANGELOG

> Signed-off-by: Alexis Berlemont <alexis.berlemont@xxxxxxxxx>
> ---

> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> index 9f72ca3..e31e8ef 100644
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -1488,6 +1488,7 @@ trace_do_page_fault(struct pt_regs *regs, unsigned long error_code)
>  	prev_state = exception_enter();
>  	trace_page_fault_entries(address, regs, error_code);
>  	__do_page_fault(regs, error_code, address);
> +	trace_page_fault_exit(address);

Aside from my general hatred of tracepoint, it bugs me that its not
symmetric like the irq vector ones. But I'll leave that to x86 people.

>  	exception_exit(prev_state);
>  }
>  NOKPROBE_SYMBOL(trace_do_page_fault);
> -- 
> 2.10.1
>