Re: [PATCH v7 0/5] mxs-lradc: Split driver into MFD

[Lee Jones]

On Sun, 02 Oct 2016, Ksenija Stanojevic wrote:

> Split existing driver mxs-lradc into MFD with touchscreen and
> IIO part.
> 
> Tested on I.MX28.
> 
> Ksenija Stanojevic (5):
>   mfd: mxs-lradc: Add support for mxs-lradc MFD
>   iio: adc: mxs-lradc: Add support for adc driver
>   input: touchscreen: mxs-lradc: Add support for touchscreen
>   iio: adc: mxs-lradc: Remove driver
>   mfd: Move binding document
> 
>  .../devicetree/bindings/iio/adc/mxs-lradc.txt      |   47 -
>  .../devicetree/bindings/mfd/mxs-lradc.txt          |   47 +
>  drivers/iio/adc/Kconfig                            |   27 +-
>  drivers/iio/adc/Makefile                           |    2 +-
>  drivers/iio/adc/mxs-lradc.c                        | 1750 --------------------

I guess you forgot to add the driver?

As much as I like patches with more '-'es than '+'es.

>  drivers/input/touchscreen/Kconfig                  |   10 +
>  drivers/input/touchscreen/Makefile                 |    1 +
>  drivers/mfd/Kconfig                                |   17 +
>  drivers/mfd/Makefile                               |    1 +
>  9 files changed, 90 insertions(+), 1812 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
>  create mode 100644 Documentation/devicetree/bindings/mfd/mxs-lradc.txt
>  delete mode 100644 drivers/iio/adc/mxs-lradc.c
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog