Re: [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF

[Lee Jones]

On Fri, 14 Oct 2016, Javier Martinez Canillas wrote:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
> alias:          platform:mx25-tsadc
> 
> After this patch:
> 
> $ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
> alias:          platform:mx25-tsadc
> alias:          of:N*T*Cfsl,imx25-tsadcC*
> alias:          of:N*T*Cfsl,imx25-tsadc
> 
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> ---
> 
>  drivers/mfd/fsl-imx25-tsadc.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index 77b2675cf8f5..ac430a396a89 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -187,6 +187,7 @@ static const struct of_device_id mx25_tsadc_ids[] = {
>  	{ .compatible = "fsl,imx25-tsadc" },
>  	{ /* Sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, mx25_tsadc_ids);
>  
>  static struct platform_driver mx25_tsadc_driver = {
>  	.driver = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog