Re: [PATCH v8 5/6] mfd: lpc_ich: Add Device IDs for Intel Apollo Lake PCH

[Lee Jones]

On Wed, 26 Oct 2016, Lee Jones wrote:

> On Wed, 12 Oct 2016, Tan Jui Nee wrote:
> 
> > Adding Intel codename Apollo Lake platform device IDs for PCH.
> > 
> > Signed-off-by: Tan Jui Nee <jui.nee.tan@xxxxxxxxx>
> > ---
> > Changes in V8:
> > 	- No change
> > 
> >  drivers/mfd/lpc_ich_core.c  | 6 ++++++
> >  include/linux/mfd/lpc_ich.h | 1 +
> >  2 files changed, 7 insertions(+)
> 
> For my own reference:
>   Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

I should really be clear.

Please add my Ack when resubmitting this patch-set.

> > diff --git a/drivers/mfd/lpc_ich_core.c b/drivers/mfd/lpc_ich_core.c
> > index bfba832..27e7e63 100644
> > --- a/drivers/mfd/lpc_ich_core.c
> > +++ b/drivers/mfd/lpc_ich_core.c
> > @@ -56,6 +56,7 @@
> >   *	document number TBD : Wildcat Point-LP
> >   *	document number TBD : 9 Series
> >   *	document number TBD : Lewisburg
> > + *	document number TBD : Apollo Lake
> >   */
> >  
> >  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > @@ -460,6 +461,10 @@ struct lpc_ich_priv {
> >  		.name = "9 Series",
> >  		.iTCO_version = 2,
> >  	},
> > +	[LPC_APL]  = {
> > +		.name = "Apollo Lake SoC",
> > +		.iTCO_version = 5,
> > +	},
> >  };
> >  
> >  /*
> > @@ -608,6 +613,7 @@ struct lpc_ich_priv {
> >  	{ PCI_VDEVICE(INTEL, 0x3b14), LPC_3420},
> >  	{ PCI_VDEVICE(INTEL, 0x3b16), LPC_3450},
> >  	{ PCI_VDEVICE(INTEL, 0x5031), LPC_EP80579},
> > +	{ PCI_VDEVICE(INTEL, 0x5ae8), LPC_APL},
> >  	{ PCI_VDEVICE(INTEL, 0x8c40), LPC_LPT},
> >  	{ PCI_VDEVICE(INTEL, 0x8c41), LPC_LPT},
> >  	{ PCI_VDEVICE(INTEL, 0x8c42), LPC_LPT},
> > diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
> > index 42307ee..397008c 100644
> > --- a/include/linux/mfd/lpc_ich.h
> > +++ b/include/linux/mfd/lpc_ich.h
> > @@ -112,6 +112,7 @@ enum lpc_chipsets {
> >  	LPC_BRASWELL,	/* Braswell SoC */
> >  	LPC_LEWISBURG,	/* Lewisburg */
> >  	LPC_9S,		/* 9 Series */
> > +	LPC_APL,	/* Apollo Lake SoC */
> >  };
> >  
> >  #endif
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog