Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version

[David Lechner]

On 10/26/2016 05:54 AM, Sekhar Nori wrote:
> On Monday 24 October 2016 08:45 PM, David Lechner wrote:
> > On 10/24/2016 06:35 AM, Sekhar Nori wrote:
> > > On Saturday 22 October 2016 12:06 AM, David Lechner wrote:
> > > > In the davinci default configuration, don't append the git revision to
> > > > the local kernel version by. This seems like the more desirable default
> > > > value.
> > >
> > > Why? To the contrary I actually quite like the fact that the git commit
> > > is appended to version string. Makes it easy for me to cross-check that
> > > I am booting the right image.
> > >
> > > > Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> > >
> > > Thanks,
> > > Sekhar
> >
> > Each time you make a commit, you get a new version, which installs
> > another copy of the kernel modules on the device. This will fill up the
> > SD card if you are making many commits.
>
> Right, but thats easily fixable by removing existing modules before
> installing new ones.
>
> > Also, if someone wants to build the mainline kernel using the default
> > configuration, it seems odd to have a git revision tacked on to the end
> > even though you made no revisions.
>
> If you checkout a tag and build, then no commit information is added.
> Which I guess is what most end users will do.
>
> I don't see this done in other defconfigs like omap2plus and multi_v7 as
> well. I would like to keep it similar for davinci.
>
> Thanks,
> Sekhar

OK, I will drop this patch.