Re: [PATCH v6 1/9] sched: Extend scheduler's asym packing

[Thomas Gleixner]

On Wed, 26 Oct 2016, Tim Chen wrote:
> On Wed, 2016-10-26 at 12:27 +0200, Thomas Gleixner wrote:
> > On Thu, 20 Oct 2016, Tim Chen wrote:
> > 
> > > 
> > > We generalize the scheduler's asym packing to provide an ordering
> > > of the cpu beyond just the cpu number.ÂÂThis allows the use of the
> > > ASYM_PACKING scheduler machinery to move loads to preferred CPU in a
> > > sched domain. The preference is defined with the cpu priority
> > > given by arch_asym_cpu_priority(cpu).
> > > 
> > > We also record the most preferred cpu in a sched group when
> > > we build the cpu's capacity for fast lookup of preferred cpu
> > > during load balancing.
> > > 
> > > Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > This SOB-chain is bogus. Same for all other patches.
> > 
> 
> I am the primary author of the patch so I have my sign-off on top. ÂThere
> were also much internal discussions/reviews between myself, Peter and Srinivas,
> before we post the first version of this patch.
> I incorporated their inputs into the patch and added their sign-offs. Â
> 
> Can you be more explicit on why you think the sign-offs here are bogus?

Because SOB chains document the way a patch takes from the author to the
kernel. The above says:

You authored the patch and sent it to Peter who sent it to Srinivas. So how
does it end up sent from you in my inbox?

We have no formal tag for co developed patches, but it's common practice to
either acknowledge contributions from others in free text form or use a
non-documented tag like 'Co-developed-by:' or 'Co-authored-by:'.

Thanks,

	tglx