Re: [RFC PATCH 02/13] of: Remove excessive printks to reduce clutter

[Pantelis Antoniou]

Hi Rob, Frank,

> On Oct 27, 2016, at 15:21 , Rob Herring <robh+dt@xxxxxxxxxx> wrote:
> 
> On Tue, Oct 25, 2016 at 3:58 PM,  <frowand.list@xxxxxxxxx> wrote:
>> From: Frank Rowand <frank.rowand@xxxxxxxxxxx>
> 
> Maybe some should be debug?
> 

Yes, please do not get rid of them completely.
Leave them at least as debug level so that if thereâs a problem
thereâs a way to figure out why something happened.

>> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxxxxx>
>> ---
>> drivers/of/resolver.c | 28 ----------------------------
>> 1 file changed, 28 deletions(-)
>> 
>> diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
>> index 4ff0220d7aa2..93a7ca0bf98c 100644
>> --- a/drivers/of/resolver.c
>> +++ b/drivers/of/resolver.c
>> @@ -116,8 +116,6 @@ static int __of_adjust_phandle_ref(struct device_node *node,
>> 
>>        propval = kmalloc(rprop->length, GFP_KERNEL);
>>        if (!propval) {
>> -               pr_err("%s: Could not copy value of '%s'\n",
>> -                               __func__, rprop->name);
>>                return -ENOMEM;
>>        }
> 
> I would remove the brackets in this patch rather than separately.
> 
>>        memcpy(propval, rprop->value, rprop->length);


Regards

â Pantelis