Re: [patch v1 2/2] drivers/platform/x86: add mlxcpld-hotplug driver registration to mlx-platform driver

[Andy Shevchenko]

On Thu, 2016-10-27 at 13:59 +0000, vadimp@xxxxxxxxxxxx wrote:
> From: Vadim Pasternak <vadimp@xxxxxxxxxxxx>

Care to fix that ^^^ ? (Hint: it shouldn't be there if author and
submitter is the same guy)


> Add calls for mlxcpld-hotplug platform driver
> registration/unregistration
> and add platform hotplug data configurations.

Would you provide more information what is done, where it is described
in the specs and how user can utilize the change?

> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -37,8 +37,9 @@
> Â#include <linux/i2c.h>
> Â#include <linux/i2c-mux.h>
> Â#include <linux/module.h>

> -#include <linux/platform_device.h>

This...

> Â#include <linux/platform_data/i2c-mux-reg.h>
> +#include <linux/platform_data/mlxcpld-hotplug.h>


> +#include <linux/platform_device.h>

...and this doesn't belong to the patch.


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy