Re: [PATCH v12 5/5] Input: goodix - add support for gt9157

[Bastien Nocera]

On Sat, 2016-09-10 at 20:57 +0300, Irina Tirdea wrote:
> Goodix touchscreen GT9157 has the same basic functionality
> as GT911 touchscreen. This is based on Goodix datasheets
> for GT911 and GT9157 and on Goodix driver gt9xx.c for
> Android (publicly available in Android kernel trees for
> various devices).
> 
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>

Looks obviously correct.

Reviewed-by: Bastien Nocera <hadess@xxxxxxxxxx>

> ---
> ÂDocumentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 +
> Âdrivers/input/touchscreen/goodix.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 2
> ++
> Â2 files changed, 3 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index ef5f42d..421b7d5 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -5,6 +5,7 @@ Required properties:
> Â - compatible		: Should be "goodix,gt911"
> Â				Âor "goodix,gt9110"
> Â				Âor "goodix,gt912"
> +				Âor "goodix,gt9157"
> Â				Âor "goodix,gt927"
> Â				Âor "goodix,gt9271"
> Â				Âor "goodix,gt928"
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index 6fba804..bd4dd4b 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -192,6 +192,7 @@ static int goodix_get_cfg_len(u16 id)
> Â	case 911:
> Â	case 9271:
> Â	case 9110:
> +	case 9157:
> Â	case 927:
> Â	case 928:
> Â		return GOODIX_CONFIG_911_LENGTH;
> @@ -1168,6 +1169,7 @@ static const struct of_device_id
> goodix_of_match[] = {
> Â	{ .compatible = "goodix,gt911" },
> Â	{ .compatible = "goodix,gt9110" },
> Â	{ .compatible = "goodix,gt912" },
> +	{ .compatible = "goodix,gt9157" },
> Â	{ .compatible = "goodix,gt927" },
> Â	{ .compatible = "goodix,gt9271" },
> Â	{ .compatible = "goodix,gt928" },