Re: [PATCH] can: fix warning in bcm_connect/proc_register

[Cong Wang]

On Thu, Oct 27, 2016 at 1:45 AM, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 10/24/2016 10:17 PM, Cong Wang wrote:
>> On Mon, Oct 24, 2016 at 1:10 PM, Cong Wang <xiyou.wangcong@xxxxxxxxx> wrote:
>>> On Mon, Oct 24, 2016 at 12:11 PM, Oliver Hartkopp
>>> <socketcan@xxxxxxxxxxxx> wrote:
>>>>         if (proc_dir) {
>>>>                 /* unique socket address as filename */
>>>>                 sprintf(bo->procname, "%lu", sock_i_ino(sk));
>>>>                 bo->bcm_proc_read = proc_create_data(bo->procname, 0644,
>>>>                                                      proc_dir,
>>>>                                                      &bcm_proc_fops, sk);
>>>> +               if (!bo->bcm_proc_read) {
>>>> +                       ret = -ENOMEM;
>>>> +                       goto fail;
>>>> +               }
>>>
>>> Well, I meant we need to call proc_create_data() once per socket,
>>> so we need a check before proc_create_data() too.
>>
>> Hmm, bo->bound should guarantee it, so never mind, your patch
>> looks fine.
>
> Can I add your Acked-by?

Of course.

Acked-by: Cong Wang <xiyou.wangcong@xxxxxxxxx>

Thanks.