Re: [GIT PULL] Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec()

[Joonwoo Park]

On 10/28/2016 10:39 AM, Ingo Molnar wrote:
> * Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
>
> > Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu:
> > > > Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu:
> > > > > Hmm.. I didn't ACK this patch because of bug I commented at
> > > > > https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1256724.html
> >
> > > > > s/work_list->max_lat/work_list->max_lat_at/
> >
> > > > Sorry about that, I took the "thanks for taking care of this" as an ack,
> > > > now that I re-read that message I saw your points later on in that
> > > > e-mail.

No worries.  I think I could be more specific with the first part of 
comment by mentioning about the bug.

> > > > Since Ingo hasn't pulled this, I'll try fixing it, will check that other
> > > > naming issue,
> >
> > > So, here is how it ended up, it fixes the problem you pointed out and
> > > renames the function to follow the scnprintf() convention, as used
> > > elsewhere in tools/perf (tools/perf/util/annotate.h has several
> > > examples).
> >
> > Ingo, I've just signed a perf-core-for-mingo-20161028 with the only
> > change being the patch below, re-run my tests, I think this doesn't
> > introduce any bugs and addresses Joonwoo's concerns, please consider
> > pulling.
>
> Pulled, thanks a lot Arnaldo!

Thanks!

Joonwoo

> 	Ingo