Re: [PATCH] Revert "usb: dwc2: gadget: fix TX FIFO size and address initialization"
From: John Youn
Date: Fri Oct 28 2016 - 14:23:09 EST
On 10/28/2016 8:52 AM, Leo Yan wrote:
> This reverts commit aa381a7259c3f53727bcaa8c5f9359e940a0e3fd.
>
> Reverting this patch, as it incorrectly assumes TX FIFO size is fixed
> and cannot change FIFO size; it removes all related dt binding code
> and have no chance to set FIFO size at init phase.
>
> As result, Hi6220 cannot set correct FIFO size for gadget driver and
> ethernet on USB function driver is easily to hang. And in the kernel
> there also have other platforms set FIFO size for usb controller,
> e.g. arch/arm64/boot/dts/rockchip/rk3368.dtsi.
>
> This patch re-enables dt binding to set FIFO size.
>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
This is already queued for 4.9-rc in Felipe's tree.
Hi Felipe,
It seems like your fixes branch for 4.9-rc2 didn't get merged
upstream. Can we get them pulled for the next -rc? There are platforms
that are broken on 4.9 without them.
Thanks,
John