Re: [PATCH] add one parameter wro_enable to enable relaxed ordering for IXGBE

[Jeff Kirsher]

On Sat, 2016-10-29 at 15:08 +0800, Mao Wenan wrote:
> This patch provides a way to enable relaxed ordering, where it helps with
> performance in some architecture.
> The default value of wro_enable is 0, if you want to enable relaxed
> ordering, please set wro_enable=1.
> 
> Mao Wenan (1):
> Â add one parameter wro_enable for IXGBE
> 
> Âdrivers/net/ethernet/intel/ixgbe/ixgbe.hÂÂÂÂÂÂÂ |Â 1 +
> Âdrivers/net/ethernet/intel/ixgbe/ixgbe_82598.c | 29 ++++++++++++++-----
> ------
> Âdrivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 28 +++++++++++++----
> -------
> Âdrivers/net/ethernet/intel/ixgbe/ixgbe_main.cÂÂ |Â 9 ++++++++
> Â4 files changed, 41 insertions(+), 26 deletions(-)

Why have a title patch for only one patch? ÂBetter yet, the one patch does
not have a patch description. ÂGet rid of the title patch and add the above
information into the patches description.

In addition, module parameters are not kindly looked upon, one reason is
that it cannot be standardized and enforced.

I am also confused because you are stating that on some architectures, yet
this code is only compiled in when SPARC is defined and that there are
times when you want relaxed ordering enabled and other times disabled?
ÂYour gonna have to provide more data on why, because the code as is was
resolving serious performance issues on SPARC when relaxed ordering was
enabled.

Attachment: signature.asc
Description: This is a digitally signed message part