Re: [PATCH] pinctrl: max77620: add OF dependency

[Linus Walleij]

On Fri, Oct 28, 2016 at 10:19 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> Drivers using pinconf_generic_params tables cannot be built with
> CONFIG_OF disabled:
>
> drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type âstruct pinconf_generic_paramsâ
> drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
> drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for âmax77620_cfg_paramsâ)
> drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer
>
> This adds a dependency for max77620 to disallow that configuration.
>
> Alternatively, we could rework the pinctrl infrastructure to make the
> configuration valid for compile-testing.
>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Patch applied.

Yours,
Linus Walleij