Re: [RFC PATCH] kbuild: add -fno-PIE
From: Sven Joachim
Date: Sat Oct 29 2016 - 13:05:06 EST
On 2016-10-29 12:10 +0200, Tomas Janousek wrote:
> On Mon, Oct 24, 2016 at 07:32:30PM +0200, Sven Joachim wrote:
>> The attached patch works for me with Debian's gcc-6 package.
>
> I tried your patch when building 4.8.5 on an up-to-date Debian testing and
> still got this:
>
> AS arch/x86/entry/vdso/vdso32/note.o
> arch/x86/entry/vdso/vdso32/note.S:1:0: sorry, unimplemented: -mfentry
> isnât supported for 32-bit in combination with -fpic
I cannot reproduce that, FWIW. Also, arch/x86/entry/vdso/Makefile seems
to explicitly filter out -mfentry from the compiler flags, but maybe I
misunderstand something.
Could you please show the exact command that's failing with "make V=1"?
> Adding KBUILD_AFLAGS += $(call cc-option,-fno-pie,) helps.
> (Maybe that should be as-option instead. Don't know. There are lots of
> AFLAGS=$(call cc-option, ...) in the Makefiles, anyway.)
This is what Ubuntu is doing, so it works at least for them, I suppose.
Cheers,
Sven