Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

[kbuild test robot]

Hi Joel,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.9-rc3 next-20161028]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Joel-Holdsworth/of-Add-vendor-prefix-for-Lattice-Semiconductor/20161030-053525
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   drivers/fpga/ice40-spi.c:203:1: warning: data definition has no type or storage class
    MODULE_DEVICE_TABLE(of, ice40_fpga_of_match);
    ^~~~~~~~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:203:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
   drivers/fpga/ice40-spi.c:203:1: warning: parameter names (without types) in function declaration
   In file included from include/linux/platform_device.h:14:0,
                    from include/linux/fpga/fpga-mgr.h:19,
                    from drivers/fpga/ice40-spi.c:14:
   include/linux/device.h:1353:1: warning: data definition has no type or storage class
    module_init(__driver##_init); \
    ^
   include/linux/spi/spi.h:290:2: note: in expansion of macro 'module_driver'
     module_driver(__spi_driver, spi_register_driver, \
     ^~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: note: in expansion of macro 'module_spi_driver'
    module_spi_driver(ice40_fpga_driver);
    ^~~~~~~~~~~~~~~~~
>> include/linux/device.h:1353:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
    module_init(__driver##_init); \
    ^
   include/linux/spi/spi.h:290:2: note: in expansion of macro 'module_driver'
     module_driver(__spi_driver, spi_register_driver, \
     ^~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: note: in expansion of macro 'module_spi_driver'
    module_spi_driver(ice40_fpga_driver);
    ^~~~~~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: warning: parameter names (without types) in function declaration
   In file included from include/linux/platform_device.h:14:0,
                    from include/linux/fpga/fpga-mgr.h:19,
                    from drivers/fpga/ice40-spi.c:14:
   include/linux/device.h:1358:1: warning: data definition has no type or storage class
    module_exit(__driver##_exit);
    ^
   include/linux/spi/spi.h:290:2: note: in expansion of macro 'module_driver'
     module_driver(__spi_driver, spi_register_driver, \
     ^~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: note: in expansion of macro 'module_spi_driver'
    module_spi_driver(ice40_fpga_driver);
    ^~~~~~~~~~~~~~~~~
>> include/linux/device.h:1358:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
    module_exit(__driver##_exit);
    ^
   include/linux/spi/spi.h:290:2: note: in expansion of macro 'module_driver'
     module_driver(__spi_driver, spi_register_driver, \
     ^~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: note: in expansion of macro 'module_spi_driver'
    module_spi_driver(ice40_fpga_driver);
    ^~~~~~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: warning: parameter names (without types) in function declaration
   drivers/fpga/ice40-spi.c:217:15: error: expected declaration specifiers or '...' before string constant
    MODULE_AUTHOR("Joel Holdsworth <joel@xxxxxxxxxxxxxxxxxxx>");
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:218:20: error: expected declaration specifiers or '...' before string constant
    MODULE_DESCRIPTION("Lattice iCE40 FPGA Manager");
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:219:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL v2");
                   ^~~~~~~~
   In file included from include/linux/platform_device.h:14:0,
                    from include/linux/fpga/fpga-mgr.h:19,
                    from drivers/fpga/ice40-spi.c:14:
   drivers/fpga/ice40-spi.c:215:19: warning: 'ice40_fpga_driver_exit' defined but not used [-Wunused-function]
    module_spi_driver(ice40_fpga_driver);
                      ^
   include/linux/device.h:1354:20: note: in definition of macro 'module_driver'
    static void __exit __driver##_exit(void) \
                       ^~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: note: in expansion of macro 'module_spi_driver'
    module_spi_driver(ice40_fpga_driver);
    ^~~~~~~~~~~~~~~~~
   drivers/fpga/ice40-spi.c:215:19: warning: 'ice40_fpga_driver_init' defined but not used [-Wunused-function]
    module_spi_driver(ice40_fpga_driver);
                      ^
   include/linux/device.h:1349:19: note: in definition of macro 'module_driver'
    static int __init __driver##_init(void) \
                      ^~~~~~~~
   drivers/fpga/ice40-spi.c:215:1: note: in expansion of macro 'module_spi_driver'
    module_spi_driver(ice40_fpga_driver);
    ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +1353 include/linux/device.h

907d0ed1 Lars-Peter Clausen 2011-11-16  1347   */
cd494618 Lars-Peter Clausen 2012-02-25  1348  #define module_driver(__driver, __register, __unregister, ...) \
907d0ed1 Lars-Peter Clausen 2011-11-16  1349  static int __init __driver##_init(void) \
907d0ed1 Lars-Peter Clausen 2011-11-16  1350  { \
cd494618 Lars-Peter Clausen 2012-02-25  1351  	return __register(&(__driver) , ##__VA_ARGS__); \
907d0ed1 Lars-Peter Clausen 2011-11-16  1352  } \
907d0ed1 Lars-Peter Clausen 2011-11-16 @1353  module_init(__driver##_init); \
907d0ed1 Lars-Peter Clausen 2011-11-16  1354  static void __exit __driver##_exit(void) \
907d0ed1 Lars-Peter Clausen 2011-11-16  1355  { \
cd494618 Lars-Peter Clausen 2012-02-25  1356  	__unregister(&(__driver) , ##__VA_ARGS__); \
907d0ed1 Lars-Peter Clausen 2011-11-16  1357  } \
907d0ed1 Lars-Peter Clausen 2011-11-16 @1358  module_exit(__driver##_exit);
907d0ed1 Lars-Peter Clausen 2011-11-16  1359  
f309d444 Paul Gortmaker     2015-05-01  1360  /**
f309d444 Paul Gortmaker     2015-05-01  1361   * builtin_driver() - Helper macro for drivers that don't do anything

:::::: The code at line 1353 was first introduced by commit
:::::: 907d0ed1c84114d4e8dafd66af982515d3739c90 drivercore: Generalize module_platform_driver

:::::: TO: Lars-Peter Clausen <lars@xxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip