Re: [PATCH v6 1/2] x86/msr: Add write msr notrace
From: Wanpeng Li
Date: Sun Oct 30 2016 - 21:41:26 EST
2016-10-31 7:46 GMT+08:00 Borislav Petkov <bp@xxxxxxxxx>:
> On Mon, Oct 31, 2016 at 07:30:33AM +0800, Wanpeng Li wrote:
>> Other functions like native_write_msr() and native_write_msr_safe()
>> etc are also not aligned, so your suggestion maybe result in
>> inconsistent.
>
> So align them too, while you're at it.
>
>> > And because we know what those are, you can convert them directly to u32.
>>
>> Ditto.
>
> You could convert the rest to u32/u64 in another patch, ontop or if you
> don't feel like it, I can take care of it.
I just fix my own "storage class should be at the beginning of the
declaration" coding style issue. Please feel free to handle align/u32
issues which existing before the patchset if you like. :)
Regards,
Wanpeng Li