Re: [PATCH v7 1/4] ARM: davinci: da8xx: Add USB PHY platform declaration

[Sekhar Nori]

On Thursday 27 October 2016 05:48 AM, David Lechner wrote:
> There is now a proper phy driver for the DA8xx SoC USB PHY. This adds the
> platform device declarations needed to use it.
> 
> Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> ---
> 
> Updated this patch so that it applies/builds cleanly before "ARM: davinci:
> da8xx: add usb phy clocks" since that patch now uses da8xx_usb_phy from this
> patch.
> 
> 
>  arch/arm/mach-davinci/board-da830-evm.c     | 22 +++++++---------------
>  arch/arm/mach-davinci/board-omapl138-hawk.c |  5 +++++
>  arch/arm/mach-davinci/include/mach/da8xx.h  |  1 +
>  arch/arm/mach-davinci/usb-da8xx.c           | 11 +++++++++++
>  4 files changed, 24 insertions(+), 15 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c
> index 2a96b40..829f68d 100644
> --- a/arch/arm/mach-davinci/board-da830-evm.c
> +++ b/arch/arm/mach-davinci/board-da830-evm.c
> @@ -26,7 +26,6 @@
>  #include <linux/platform_data/mtd-davinci.h>
>  #include <linux/platform_data/mtd-davinci-aemif.h>
>  #include <linux/platform_data/spi-davinci.h>
> -#include <linux/platform_data/usb-davinci.h>

I applied this patch, but did not drop this include. usb-davinci.h 
provides the definition of da8xx_ohci_root_hub which is still used in 
this file. I guess it did not lead to a build error because the file is 
still getting included indirectly. But I rather prefer a direct include 
of this file.

Attached is the patch I applied for reference.

Thanks,
Sekhar

---8<---