Re: [PATCH v1 1/3] dt-bindings: Document Broadcom OTP controller driver

[Jonathan Richardson]

On 16-10-30 06:38 PM, Rob Herring wrote:
> On Mon, Oct 24, 2016 at 12:12:02PM -0700, Jonathan Richardson wrote:
>> From: Jonathan Richardson <jonathar@xxxxxxxxxxxx>
>>
>> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
>> Tested-by: Jonathan Richardson <jonathan.richardson@xxxxxxxxxxxx>
>> Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
>> Signed-off-by: Oza Pawandeep <oza@xxxxxxxxxxxx>
>> Signed-off-by: Jonathan Richardson <jonathan.richardson@xxxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt
>> new file mode 100644
>> index 0000000..6462e12
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nvmem/brcm,ocotp.txt
>> @@ -0,0 +1,17 @@
>> +Broadcom OTP memory controller
>> +
>> +Required Properties:
>> +- compatible: "brcm,ocotp" for the first generation Broadcom OTPC which is used
>> +  in Cygnus and supports 32 bit read/write. Use "brcm,ocotp-v2" for the second
>> +  generation Broadcom OTPC which is used in SoC's such as Stingray and supports
>> +  64-bit read/write.
> 
> These should be SoC specific. While I'd guess this block is simple 
> enough, having the SoC can define what all the bits are. Yes, there is a 
> binding to define those, but you may not use that.

Hi Rob. This block isn't SoC specific. It is used on multiple SoC's.
There are older SoC's using v1 that we may upstream drivers for in the
future. v1 isn't specific to cygnus/iproc and v2 isn't specific to stingray.

> 
> 
>> +- reg: Base address of the OTP controller.
>> +- brcm,ocotp-size: Amount of memory available, in 32 bit words
>> +
>> +Example:
>> +
>> +otp: otp@0301c800 {
>> +	compatible = "brcm,ocotp";
>> +	reg = <0x0301c800 0x2c>;
>> +	brcm,ocotp-size = <2048>;
>> +};
>> -- 
>> 1.9.1
>>