Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query

[Matt Ranostay]

On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay <mranostay@xxxxxxxxx> wrote:
> On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@xxxxxx> wrote:
>> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
>>> Pavel + Sebastian this is the patchset that need I some input on :)
>>
>> Better then previous one.
>>
>> But my version of bq27xxx_battery.c already contains this:
>
> This is for allowing udev rule to set the properties as well.
> otherwise a kinda crude RUN = " echo value >
> /sys/module/bq27xxx_battery/parameters/poll_interval" is required.

Any thoughts on this?

Thanks,

Matt


>
>>
>> static const struct kernel_param_ops param_ops_poll_interval = {
>>         .get = param_get_uint,
>>         .set = poll_interval_param_set,
>> };
>>
>> ...so it should be possible to set poll interval already.
>>
>>                                                                         Pavel
>>
>> --
>> (english) http://www.livejournal.com/~pavelmachek
>> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html