Re: [PATCH 15/60] block: loop: comment on direct access to bvec table
From: Ming Lei
Date: Mon Oct 31 2016 - 19:08:31 EST
On Mon, Oct 31, 2016 at 11:31 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> Btw, the lib/iov_iter.c code that iterates over bvec currently
> expects single-page segments. Is the loop code fine with that?
lib/iov_iter.c has switched to bvec iterator already in the mp-bvec
preparing patchset, so every thing will be fine after multipage bvec
is enabled.
Another multipage bvec benefit for lib/iov_iter.c(dio) is that we
can return whole pages in one segment, instead of one page
each time, such as iov_iter_get_pages(), but that can be
a follow-up optimization.
> Even if it is I think we'd be much better off if it becomes multipage
> segment aware.
This patch is for auditing possible effect with multipage bvec, so
looks we should expose as much as possible direct access to
bvec table.
Thanks,
Ming Lei