Re: [PATCH][resend] drm: bridge: add DesignWare HDMI I2S audio support
From: Russell King - ARM Linux
Date: Tue Nov 01 2016 - 05:38:48 EST
On Tue, Nov 01, 2016 at 12:36:29AM +0000, Kuninori Morimoto wrote:
>
> Hi Russell again
>
> > > > +static struct platform_driver snd_dw_hdmi_driver = {
> > > > + .probe = snd_dw_hdmi_probe,
> > >
> > > The driver must have a .remove function, because the platform device it
> > > is binding against can appear and disappear.
> >
> > Thank you for your feedback
> > OK, I will add it
>
> This driver uses platform_device_register_full() and calls hdmi-codec
> driver. This driver itself doesn't register sound card, like dw-hdmi-ahb-audio.c
> Then, what does .remove should do in this case ?
Remove the platform device that was created by
platform_device_register_full().
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.