Re: [PATCH] net/mlx5: Simplify a test

[David Miller]

From: Matan Barak <matanb@xxxxxxxxxxxx>
Date: Tue, 1 Nov 2016 11:38:18 +0200

> On 01/11/2016 09:10, Christophe JAILLET wrote:
>> 'create_root_ns()' does not return an error pointer, so the test can
>> be
>> simplified to be more consistent.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>> ---
>>  drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> index 904853f9cf7a..330955f6badc 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
>> @@ -1833,7 +1833,7 @@ static int init_root_ns(struct
>> mlx5_flow_steering *steering)
>>  {
>>
>>  	steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX);
>> -	if (IS_ERR_OR_NULL(steering->root_ns))
>> +	if (!steering->root_ns)
>>  		goto cleanup;
>>
>>  	if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node))
>>
> 
> Thanks.
> Acked-by: Matan Barak <matanb@xxxxxxxxxxxx>
> 

Applied.