Re: [PATCH net-next 07/11] net: dsa: mv88e6xxx: add port link setter

[Vivien Didelot]

Hi Andrew,

Andrew Lunn <andrew@xxxxxxx> writes:

>> +#define LINK_UNKNOWN	-1
>> +
>> +	/* Port's MAC link state
>> +	 * LINK_UNKNOWN for normal link detection, 0 to force link down,
>> +	 * otherwise force link up.
>> +	 */
>> +	int (*port_set_link)(struct mv88e6xxx_chip *chip, int port, int link);
>
> Maybe LINK_AUTO would be better than UNKNOWN? Or LINK_UNFORCED.

I used LINK_UNKNOWN to be consistent with the supported SPEED_UNKNOWN
and DUPLEX_UNKNOWN values of PHY devices.

Thanks,

        Vivien