Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()
From: Masahiro Yamada
Date: Wed Nov 02 2016 - 11:35:58 EST
2016-10-29 8:42 GMT+09:00 Jim Davis <jim.epost@xxxxxxxxx>:
> On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring
> <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
>> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) {
>
> Rather than scatter fragile magic numbers, like 10, throughout the
> code, if you're hell-bent on checking for printf errors you could
> write a little wrapper function that hid the magic number and bundled
> up the errno stuff.
BTW, how the magic number "10" was calculated?
--
Best Regards
Masahiro Yamada