Re: [PATCH] PCI: designware: check for iATU unroll support after initializing host

[Olof Johansson]

Hi,

On Fri, Oct 14, 2016 at 2:54 PM, Niklas Cassel <niklas.cassel@xxxxxxxx> wrote:
> From: Niklas Cassel <niklas.cassel@xxxxxxxx>
>
> dw_pcie_iatu_unroll_enabled reads a dbi_base register.
> Reading any dbi_base register before pp->ops->host_init has been called
> causes "imprecise external abort" on platforms like ARTPEC-6, where the
> PCIe module is disabled at boot and first enabled in pp->ops->host_init.
> Move dw_pcie_iatu_unroll_enabled to dw_pcie_setup_rc, since it is after
> pp->ops->host_init, but before pp->iatu_unroll_enabled is actually used.
>
> Fixes: a0601a470537 ("PCI: designware: Add iATU Unroll feature")
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxx>

This fixes the regression I've seen on i.MX6 devices in my board farm as well.

Acked-by: Olof Johansson <olof@xxxxxxxxx>

Bjorn, can you please pick this up and get it sent up for 4.9-rc soon?
I worry about losing bisectability if this remains broken for a while.
Thanks!


-Olof