Re: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections
From: Joe Perches
Date: Thu Nov 03 2016 - 05:16:48 EST
On Thu, 2016-11-03 at 10:07 +0100, Paul Bolle wrote:
> On Mon, 2016-10-24 at 11:05 -0700, Joe Perches wrote:
> > Jani Nikula proposes patches to add a few new letter prefixes
> > for "B:" bug reporting and "C:" maintainer chatting to the
> > various sections of MAINTAINERS.
> >
> > Add a generic mechanism to get_maintainer.pl to find sections that
> > have any combination of "[A-Z]" letter prefix types in a section.
> >
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>
> This patch made it into linux-next (ie, next-20161028).
>
> > --- a/scripts/get_maintainer.pl
> > +++ b/scripts/get_maintainer.pl
> > @@ -271,7 +273,8 @@ $output_multiline = 0 if ($output_separator ne ", ");
> > $output_rolestats = 1 if ($interactive);
> > $output_roles = 1 if ($output_rolestats);
> >
> > -if ($sections) {
> > +if ($sections || $letters ne "") {
> > + $sections = 1;
>
> This triggers:
> Unrecognized character \xA0; marked by <-- HERE after <-- HERE near column 1 at ./scripts/get_maintainer.pl line 277.
>
> Git blame shows:
> git blame -L 277,+1 ./scripts/get_maintainer.pl
> b67071653d3fc (Joe Perches 2016-10-28 13:22:01 +1100 277) <A0><A0><A0><A0>$sections = 1;
>
> (A0 seems to be the no break space. That character was inserted more
> often further down the patch.)
>
> Anybody else seeing this?
Yes, it's been reported and should be fixed in -mm.
The fix should show up in -next in a little bit.
For now, try:
$ sed -i -e 's/\xA0/ /g' scripts/get_maintainer.pl
cheers, Joe