Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver
From: Jacek Anaszewski
Date: Thu Nov 03 2016 - 06:39:45 EST
On 11/03/2016 11:10 AM, Andi Shyti wrote:
Hi Jacek,
Only DT bindings of LED class drivers should be placed in
Documentation/devicetree/bindings/leds. Please move it to the
media bindings.
that's where I placed it first, but Rob asked me to put it in the
LED directory and Cc the LED mailining list.
That's the discussion of the version 2:
https://lkml.org/lkml/2016/9/12/380
Rob, Jacek, could you please agree where I can put the binding?
I'm not sure if this is a good approach. I've noticed also that
backlight bindings have been moved to leds, whereas they don't look
similarly.
We have common.txt LED bindings, that all LED class drivers' bindings
have to follow. Neither backlight bindings nor these ones do that,
which introduces some mess.
Eventually adding a sub-directory, e.g. remote_control could make it
somehow logically justified, but still - shouldn't bindings be
placed in the documentation directory related to the subsystem of the
driver they are predestined to?
--
Best regards,
Jacek Anaszewski