Re: [PATCH 2/5] KVM: x86: do not scan IRR twice on APICv vmentry

[Michael S. Tsirkin]

On Thu, Nov 03, 2016 at 02:30:31PM +0100, Paolo Bonzini wrote:
> 
> 
> On 26/10/2016 21:59, Radim KrÄmÃÅ wrote:
> > 2016-10-14 20:21+0200, Paolo Bonzini:
> >> Calling apic_find_highest_irr results in IRR being scanned twice,
> >> once in vmx_sync_pir_from_irr and once in apic_search_irr.  Change
> >> sync_pir_from_irr to do the RVI write and kvm_apic_update_irr to
> >> compute the new RVI on the fly.
> >>
> >> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> >> ---
> > 
> > Reviewed-by: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>
> 
> Nope, this breaks nested VMX exit on external interrupt.  For now I'm
> testing only patch 1 and will push that one only to kvm/next.
> 
> Paolo

Do you know why? I don't see it yet.