Re: [PATCH v3 1/3] fs/exec: don't force writing memory access

From: Oleg Nesterov
Date: Thu Nov 03 2016 - 13:28:04 EST

On 11/03, Jann Horn wrote:
> This shouldn't change behavior in any way - at this point, there should be
> no non-writable mappings, only the initial stack mapping -,

So this FOLL_FORCE just adds the unnecessary confusion,

> but this change
> makes it easier to reason about the correctness of the following commits
> that place restrictions on forced memory writes.

and to me it looks like a good cleanup regardless. Exactly because it
is not clear why do we need FOLL_FORCE.

> Signed-off-by: Jann Horn <jann@xxxxxxxxx>
> Reviewed-by: Janis Danisevskis <jdanis@xxxxxxxxxxx>

Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>