Re: vmalloced stacks and scatterwalk_map_and_copy()

From: Andy Lutomirski
Date: Thu Nov 03 2016 - 23:59:51 EST

On Thu, Nov 3, 2016 at 4:10 PM, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> On Thu, Nov 03, 2016 at 02:12:07PM -0700, Eric Biggers wrote:
>> On Thu, Nov 03, 2016 at 01:30:49PM -0700, Andy Lutomirski wrote:
>> >
>> > Also, Herbert, it seems like the considerable majority of the crypto
>> > code is acting on kernel virtual memory addresses and does software
>> > processing. Would it perhaps make sense to add a kvec-based or
>> > iov_iter-based interface to the crypto code? I bet it would be quite
>> > a bit faster and it would make crypto on stack buffers work directly.
>> I'd like to hear Herbert's opinion on this too, but as I understand it, if a
>> symmetric cipher API operating on virtual addresses was added, similar to the
>> existing "shash" API it would only allow software processing. Whereas with the
>> current API you can request a transform and use it the same way regardless of
>> whether the crypto framework has chosen a software or hardware implementation,
>> or a combination thereof. If this wasn't a concern then I expect using virtual
>> addresses would indeed simplify things a lot, at least for users not already
>> working with physical memory (struct page).
>> Either way, in the near term it looks like 4.9 will be released with the new
>> behavior that encryption/decryption is not supported on stack buffers.
>> Separately from the scatterwalk_map_and_copy() issue, today I've found two
>> places in the filesystem-level encryption code that do encryption on stack
>> buffers and therefore hit the 'BUG_ON(!virt_addr_valid(buf));' in sg_set_buf().
>> I will be sending patches to fix these, but I suspect there may be more crypto
>> API users elsewhere that have this same problem.
>> Eric
> [Added linux-mm to Cc]
> For what it's worth, grsecurity has a special case to allow a scatterlist entry
> to be created from a stack buffer:
> static inline void sg_set_buf(struct scatterlist *sg, const void *buf,
> unsigned int buflen)
> {
> const void *realbuf = buf;
> if (object_starts_on_stack(buf))
> realbuf = buf - current->stack + current->lowmem_stack;
> #endif
> BUG_ON(!virt_addr_valid(realbuf));
> #endif
> sg_set_page(sg, virt_to_page(realbuf), buflen, offset_in_page(realbuf));
> }

Yes, that's how grsecurity works. The upstream version is going to do
it right instead of hacking around it.

> I don't know about all the relative merits of the two approaches. But one of
> the things that will need to be done with the currently upstream approach is
> that all callers of sg_set_buf() will need to be checked to make sure they
> aren't using stack addresses, and any that are will need to be updated to do
> otherwise, e.g. by using heap-allocated memory.

I tried to do this, but I may have missed a couple example.

> I suppose this is already
> happening, but in the case of the crypto API it will probably take a while for
> all the users to be identified and updated. (And it's not always clear from the
> local context whether something can be stack memory or not, e.g. the memory for
> crypto request objects may be either.)

The crypto request objects can live on the stack just fine. It's the
request buffers that need to live elsewhere (or the alternative
interfaces can be used, or the crypto core code can start using
something other than scatterlists).