Re: [PATCH] clk: sunxi: Fix M factor computation for APB1

From: Maxime Ripard
Date: Fri Nov 04 2016 - 03:49:46 EST

On Fri, Nov 04, 2016 at 12:53:56AM +0100, Stéphan Rafin wrote:
> commit cfa636886033 ("clk: sunxi: factors: Consolidate get_factors
> parameters into a struct") introduced a regression for m factor
> computation in sun4i_get_apb1_factors function.
> The old code reassigned the "parent_rate" parameter to the targeted
> divisor value and was buggy for the returned frequency but not for the
> computed factors. Now, returned frequency is good but m factor is
> incorrectly computed (its max value 31 is always set resulting in a
> significantly slower frequency than the requested one...)
> This patch simply restores the original proper computation for m while
> keeping the good changes for returned rate.
> Signed-off-by: Stéphan Rafin <stephan@xxxxxxxxxxxx>

Applied (added a Fixes tag), thanks


Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering

Attachment: signature.asc
Description: PGP signature