Re: [PATCH] net: 3com: typhoon: fix typhoon_get_link_ksettings

[Sergei Shtylyov]

Hello.

On 11/5/2016 6:11 PM, Philippe Reynes wrote:

> When moving from typhoon_get_settings to typhoon_getlink_ksettings
> in the commit commit f7a5537cd2a5 ("net: 3com: typhoon: use new api

   One "commit" is enough. :-)

> ethtool_{get|set}_link_ksettings"), we use a local variable supported
> but we forgot to update the struct ethtool_link_ksettings with
> this value.
>
> We also initialize advertising to zero, because otherwise it may
> be uninitialized if no case of the switch (tp->xcvr_select) is used.
>
> Signed-off-by: Philippe Reynes <tremyfr@xxxxxxxxx>
[...]

MBR, Sergei