Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs

[James Simmons]

> On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote:
> > > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> > Reviewed-by: James Simmons <jsimmons@xxxxxxxxxxxxx>
> []
> > > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> []
> > > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> > >  {
> > >  	__u64 *pages = tx->tx_pages;
> > >  	bool is_rx = (rd != tx->tx_rd);
> > > -        bool tx_pages_mapped = 0;
> > > +	bool tx_pages_mapped = 0;
> 
> It's generally better to use bool assignments to true/false not 1/0.

Nicholas can you resubmit with tx_pages_mapped = false. Looking at the 
lustre code its the only place like this. Thanks for pointing this out.