Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties

[Andy Shevchenko]

On Wed, 2016-11-02 at 11:55 +0000, Eugeniy Paltsev wrote:
> Hi Andy,
> Could you possibly tell me your ideas about these changes?
> Thanks.

Thanks for an update, but, please, answer to all my comments to your
patch v2. Either you are okay with them, then you didn't address few, or
you are not okay, I didn't get why. Deffer newer version until we get an
agreement on the implementation.

> 
> On Fri, 2016-10-28 at 18:59 +0300, Eugeniy Paltsev wrote:
> > This series is to address a proposal by Andy in these threads:
> > http://www.spinics.net/lists/dmaengine/msg11506.html
> > http://www.spinics.net/lists/dmaengine/msg11541.html
> > Split platform data to actual hardware properties, and platform
> > quirks.
> > Now we able to use quirks and hardware properties separately from
> > different sources (pdata, device tree or autoconfig registers)
> > 
> > Changes for v3:
> > Â-ÂÂÂSplit changes to separate patches.
> > Â-ÂÂÂAdd "DW_DMA_IS_LLP_SUPPORTED" flag and get rid of "dwc->nollp"
> > ÂÂÂÂÂas separate variable.
> > Â-ÂÂÂMake "dw_dma_slave" documentation comments more clear about
> > quirks.
> > ÂÂÂÂÂ"is_memcpy" and "is_private" are quirks, "is_nollp" is regularÂ
> > ÂÂÂÂÂpdata property.
> > 
> > Eugeniy Paltsev (3):
> > Â dmaengine: DW DMAC: split pdata to hardware properties and
> > platform
> > ÂÂÂÂquirks
> > Â dmaengine: DW DMAC: convert to unified device property API
> > Â dmaengine: DW DMAC: move "nollp" to "dwc->flags"
> > 
> > Âdrivers/dma/dw/core.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 34 +++++++++++++----------
> > Âdrivers/dma/dw/platform.cÂÂÂÂÂÂÂÂÂÂÂÂ| 53 +++++++++++++++++++----
> > ---
> > ----------
> > Âdrivers/dma/dw/regs.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 +-
> > Âinclude/linux/platform_data/dma-dw.h |ÂÂ5 ++++
> > Â4 files changed, 54 insertions(+), 40 deletions(-)
> > 
> 
> --Â
> ÂPaltsev Eugeniy

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy