Re: [PATCH v3] i2c: designware: Implement support for SMBus block read and write

[Andy Shevchenko]

On Mon, 2016-10-31 at 13:51 +0700, tnhuynh@xxxxxxx wrote:
> From: Tin Huynh <tnhuynh@xxxxxxx>
> 
> Free and Open IPMI use SMBUS BLOCK Read/Write to support SSIF
> protocol.
> However, I2C Designware Core Driver doesn't handle the case at the
> moment.
> The below patch supports this feature.

My comments below.


> @@ -543,6 +543,7 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev
> *dev)
> Â	intr_mask = DW_IC_INTR_DEFAULT_MASK;
> Â
> Â	for (; dev->msg_write_idx < dev->msgs_num; dev-
> >msg_write_idx++) {
> +		u32 flags = msgs[dev->msg_write_idx].flags;

+ empty line.

> Â		/*
> Â		Â* if target address has changed, we need to
> Â		Â* reprogram the target address in the i2c

> @@ -588,8 +589,15 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev
> *dev)
> Â			Â* detected from the registers so we set it
> always
> Â			Â* when writing/reading the last byte.
> Â			Â*/
> +
> +			/*
> +			Â* i2c-core.c always set the buffer length of

set -> sets

> +			Â* I2C_FUNC_SMBUS_BLOCK_DATA to 1. The length
> will
> +			Â* be adjusted when receiving the first byte.
> +			Â* Thus we can't stop the transaction here.
> +			Â*/
> 

> @@ -635,6 +648,25 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev
> *dev)
> Â	dw_writel(dev, intr_mask,ÂÂDW_IC_INTR_MASK);
> Â}
> Â
> +static u8
> +i2c_dw_recv_len(struct dw_i2c_dev *dev, u8 len)
> +{
> +	struct i2c_msg *msgs = dev->msgs;
> +	u32 flags = msgs[dev->msg_read_idx].flags;
> +
> +	/*
> +	Â* Adjust the buffer length and mask the flag
> +	Â* after receiving the first byte

Add dot to the end, please.

> +	Â*/
> +	len = (flags & I2C_CLIENT_PEC) ? len + 2 : len + 1;

len += flags & I2C_CLIENT_PEC ? 2 : 1;

> +	dev->tx_buf_len = len > dev->rx_outstanding ?
> +		len - dev->rx_outstanding : 0;

Can be len more than twice longer as rx_outstanding?

Would it be better to write as
tx_buf_len = len - min(len, rx_outstanding);
?

> +	msgs[dev->msg_read_idx].len = len;
> +	msgs[dev->msg_read_idx].flags &= ~I2C_M_RECV_LEN;
> +
> +	return len;
> +}
> +
> Âstatic void
> Âi2c_dw_read(struct dw_i2c_dev *dev)
> Â{
> @@ -659,7 +691,14 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev
> *dev)
> Â		rx_valid = dw_readl(dev, DW_IC_RXFLR);
> Â
> Â		for (; len > 0 && rx_valid > 0; len--, rx_valid--) {
> -			*buf++ = dw_readl(dev, DW_IC_DATA_CMD);
> +			u32 flags = msgs[dev->msg_read_idx].flags;

+ empty line.

> +			*buf = dw_readl(dev, DW_IC_DATA_CMD);
> +			/* Ensure length byte is a valid value */
> +			if (flags & I2C_M_RECV_LEN &&
> +				*buf <= I2C_SMBUS_BLOCK_MAX && *buf >
> 0) {

Is it my mail client or indentation is wrong?

> +				len = i2c_dw_recv_len(dev, *buf);
> +			}
> +			buf++;
> Â			dev->rx_outstanding--;
> Â		}

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy