Re: [PATCH v4 1/3] dt-bindings: mediatek: Add a binding for Mediatek JPEG Decoder

[Matthias Brugger]

On 07/11/16 07:57, Rick Chang wrote:
> Add a DT binding documentation for Mediatek JPEG Decoder of
> MT2701 SoC.
>
> Signed-off-by: Rick Chang <rick.chang@xxxxxxxxxxxx>
> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@xxxxxxxxxxxx>
> ---
>  .../bindings/media/mediatek-jpeg-codec.txt         | 35 ++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt b/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt
> new file mode 100644
> index 0000000..c7dbcc2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-codec.txt
> @@ -0,0 +1,35 @@
> +* Mediatek JPEG Decoder
> +
> +Mediatek JPEG Decoder is the JPEG decode hardware present in Mediatek SoCs
> +
> +Required properties:
> +- compatible : "mediatek,jpgdec"

Is this block in all arm SoCs from Mediatek?
If not, then I would prefer to use "mediatek,mtXXXX-jpgdec"
where XXXX stands for the oldest model which has this block.

In parallel to that the dts should have this compatible plus the one for 
mt2701, for example:
compatible = "mediatek,mt2701-uart", "mediatek,mt6577-uart"

Thanks,
Matthias