RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem

From: Winkler, Tomas
Date: Mon Nov 07 2016 - 14:27:49 EST

> On Mon, Nov 07, 2016 at 09:53:12PM +0200, Tomas Winkler wrote:
> > Register UFS RPMB LUN with the RPMB subsystem and provide
> > implementation for the RPMB access operations. RPMB partition is
> > accessed via a sequence of security protocol in and security protocol
> > out commands with UFS specific parameters. This multi step process is
> > abstracted into 4 basic RPMB commands.
> This is a giant layering violation - the security protocol is not something up to
> the LLDD but the core code.
> And honestly the idea of defintining a security protocol in the UFS spec is just
> as braindead. If you care about this please take it up with T10 to get RPMB
> support into one of the core SCSI specs instead of a transport.

I value your opinion but I'm not responsible for inventing RPMB
and/or its implementation storage devices (eMMC, UFC, NVMe), it's pretty much done deal out there in the wild.
I'm just trying to provide common API above it.