Re: [PATCH v3 2/2] USB hub_probe: put initialization before usage

From: Greg Kroah-Hartman
Date: Tue Nov 08 2016 - 01:52:45 EST


On Mon, Nov 07, 2016 at 09:55:09PM +0300, Eugene Korenevsky wrote:
> Minor optimization: move initialization immediately before usage.
> This gives a chance for more accurate register allocation by the compiler.

This is a probe function, a very slow path. Don't do micro
optimizations where they are not needed, or can not be actually
measured.

Also please just cc: the needed mailing list and maintainer for the
patch, don't go overboard for such tiny stuff.

thanks,

greg k-h