Re: [PATCH 1/3] phy: fix semicolon.cocci warnings

From: Vivek Gautam
Date: Tue Nov 08 2016 - 05:53:49 EST


Hi Kishon,

On Thu, Oct 20, 2016 at 12:23 PM, Vivek Gautam
<vivek.gautam@xxxxxxxxxxxxxx> wrote:
> Remove unneeded semicolon.
>
> Generated by: coccinellery/semicolon/semicolon.cocci
>
> Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
> Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---

Gentle ping.
Do you plan to pull in 3 patches in this series ?

> drivers/phy/phy-brcm-sata.c | 6 +++---
> drivers/phy/phy-exynos4210-usb2.c | 4 ++--
> drivers/phy/phy-exynos4x12-usb2.c | 4 ++--
> drivers/phy/phy-exynos5250-usb2.c | 2 +-
> drivers/phy/phy-rockchip-emmc.c | 2 +-
> drivers/phy/phy-s5pv210-usb2.c | 4 ++--
> 6 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
> index 8ffc44a..ccbc3d9 100644
> --- a/drivers/phy/phy-brcm-sata.c
> +++ b/drivers/phy/phy-brcm-sata.c
> @@ -140,7 +140,7 @@ static inline void __iomem *brcm_sata_pcb_base(struct brcm_sata_port *port)
> default:
> dev_err(priv->dev, "invalid phy version\n");
> break;
> - };
> + }
>
> return priv->phy_base + (port->portnum * size);
> }
> @@ -157,7 +157,7 @@ static inline void __iomem *brcm_sata_ctrl_base(struct brcm_sata_port *port)
> default:
> dev_err(priv->dev, "invalid phy version\n");
> break;
> - };
> + }
>
> return priv->ctrl_base + (port->portnum * size);
> }
> @@ -365,7 +365,7 @@ static int brcm_sata_phy_init(struct phy *phy)
> break;
> default:
> rc = -ENODEV;
> - };
> + }
>
> return rc;
> }
> diff --git a/drivers/phy/phy-exynos4210-usb2.c b/drivers/phy/phy-exynos4210-usb2.c
> index f30bbb0..1f50e10 100644
> --- a/drivers/phy/phy-exynos4210-usb2.c
> +++ b/drivers/phy/phy-exynos4210-usb2.c
> @@ -141,7 +141,7 @@ static void exynos4210_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
> }
> @@ -179,7 +179,7 @@ static void exynos4210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
> rstbits = EXYNOS_4210_URSTCON_PHY1_P1P2 |
> EXYNOS_4210_URSTCON_HOST_LINK_P2;
> break;
> - };
> + }
>
> if (on) {
> clk = readl(drv->reg_phy + EXYNOS_4210_UPHYCLK);
> diff --git a/drivers/phy/phy-exynos4x12-usb2.c b/drivers/phy/phy-exynos4x12-usb2.c
> index 765da90..7f27a91 100644
> --- a/drivers/phy/phy-exynos4x12-usb2.c
> +++ b/drivers/phy/phy-exynos4x12-usb2.c
> @@ -187,7 +187,7 @@ static void exynos4x12_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
> }
> @@ -237,7 +237,7 @@ static void exynos4x12_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
> rstbits = EXYNOS_4x12_URSTCON_HSIC1 |
> EXYNOS_4x12_URSTCON_HOST_LINK_P1;
> break;
> - };
> + }
>
> if (on) {
> pwr = readl(drv->reg_phy + EXYNOS_4x12_UPHYPWR);
> diff --git a/drivers/phy/phy-exynos5250-usb2.c b/drivers/phy/phy-exynos5250-usb2.c
> index 2ed1735..aad8062 100644
> --- a/drivers/phy/phy-exynos5250-usb2.c
> +++ b/drivers/phy/phy-exynos5250-usb2.c
> @@ -192,7 +192,7 @@ static void exynos5250_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, offset, mask, on ? 0 : mask);
> }
> diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c
> index fd57345..f1b24f1 100644
> --- a/drivers/phy/phy-rockchip-emmc.c
> +++ b/drivers/phy/phy-rockchip-emmc.c
> @@ -132,7 +132,7 @@ static int rockchip_emmc_phy_power(struct phy *phy, bool on_off)
> default:
> ideal_rate = 200000000;
> break;
> - };
> + }
>
> diff = (rate > ideal_rate) ?
> rate - ideal_rate : ideal_rate - rate;
> diff --git a/drivers/phy/phy-s5pv210-usb2.c b/drivers/phy/phy-s5pv210-usb2.c
> index 004d320..f6f7233 100644
> --- a/drivers/phy/phy-s5pv210-usb2.c
> +++ b/drivers/phy/phy-s5pv210-usb2.c
> @@ -103,7 +103,7 @@ static void s5pv210_isol(struct samsung_usb2_phy_instance *inst, bool on)
> break;
> default:
> return;
> - };
> + }
>
> regmap_update_bits(drv->reg_pmu, S5PV210_USB_ISOL_OFFSET,
> mask, on ? 0 : mask);
> @@ -127,7 +127,7 @@ static void s5pv210_phy_pwr(struct samsung_usb2_phy_instance *inst, bool on)
> rstbits = S5PV210_URSTCON_PHY1_ALL |
> S5PV210_URSTCON_HOST_LINK_ALL;
> break;
> - };
> + }
>
> if (on) {
> writel(drv->ref_reg_val, drv->reg_phy + S5PV210_UPHYCLK);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>



--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project